Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require a global .gitconfig file to exist (when loading the Repository Settings Widget) #376

Closed
MrCodingB opened this issue Sep 7, 2020 · 3 comments
Assignees
Labels
improvement An improvement to existing functionality
Projects
Milestone

Comments

@MrCodingB
Copy link

MrCodingB commented Sep 7, 2020

Describe the Bug
GitGraph seems to need a global git configuration even if there's a local one.

Steps to Reproduce

  1. Don't have any git configuration (you can just rename your global one to .gitconfigs or anything)
  2. Make a new repo
  3. Try to open the settings in the GitGraph view
  4. You'll get an error that GitGraph can't find a .gitconfig file in the user folder

Expected Behaviour
GitGraph detects the local configuration and doesn't care about any global ones (if all required settings are there)

Environment

  • Git Graph Extension Version: 1.25.0
  • Visual Studio Code Version: 1.48.2
  • Operating System: Windows 10
@MrCodingB MrCodingB added the bug Something isn't working label Sep 7, 2020
@MrCodingB
Copy link
Author

Also I just tested it and it doesn't matter whether or not the global .gitconfig has any content....as long as ist's there it works, but as soon as you rename it or remove it, git graph doesn't let you change any settings

@mhutchie
Copy link
Owner

mhutchie commented Sep 9, 2020

Hi @MrCodingB,

Git Graph currently requires a global .gitconfig file to exist, as the Git Graph View's Setting Widget allows users to set the local and global user name & email address (and it needs to know the corresponding values). It seemed to be a fairly reasonable assumption that users would either already have a global .gitconfig file, or wouldn't mind creating one as it's easy to do. None of the other ~630,000 users of Git Graph previously indicated they both didn't have a global .gitconfig, nor wanted to create one.

It's an easy change for me to make to not require a global .gitconfig file, so I'll make this change in the next few hours and publish a beta release for you to use immediately.

@mhutchie mhutchie added improvement An improvement to existing functionality and removed bug Something isn't working labels Sep 9, 2020
@mhutchie mhutchie added this to To Do in Git Graph via automation Sep 9, 2020
@mhutchie mhutchie added this to the v1.26.0 milestone Sep 9, 2020
@mhutchie mhutchie moved this from To Do to In Progress in Git Graph Sep 9, 2020
mhutchie added a commit that referenced this issue Sep 9, 2020
@mhutchie mhutchie changed the title Global GitConfig required Don't require a global .gitconfig file to exist (when loading the Repository Settings Widget) Sep 9, 2020
@mhutchie
Copy link
Owner

mhutchie commented Sep 9, 2020

This will be available in v1.26.0.

If you'd like to use it before the next release, you can download v1.26.0-beta.5, and install it following the instructions provided here.

@mhutchie mhutchie closed this as completed Sep 9, 2020
Git Graph automation moved this from In Progress to Ready For Release Sep 9, 2020
@mhutchie mhutchie moved this from Ready For Release to Released in Git Graph Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An improvement to existing functionality
Projects
Git Graph
Released
Development

No branches or pull requests

2 participants