Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow commit and tags signing #399

Closed
AngheloAlf opened this issue Oct 18, 2020 · 2 comments
Closed

Allow commit and tags signing #399

AngheloAlf opened this issue Oct 18, 2020 · 2 comments
Assignees
Labels
feature request Feature request
Projects
Milestone

Comments

@AngheloAlf
Copy link

Describe the feature that you'd like

git allows to sign commits and tags¹ using the flags -S and -s respectively.
It could be great if git-graph could sign¹ every action it is performed in its GUI.

Additional context (optional)

vscode already has a setting to enable this:
image
With this option enabled, every action done using the built-in GUI is signed. But, git-graph does not support this, so mixing actions between both (like making commits in vscode and merging branches in git-graph) produce a mix of signed and unsigned commits.

I suggest to check if that option is enabled and sign accordingly.


¹ if the user has previously configured their keys.

@AngheloAlf AngheloAlf added the feature request Feature request label Oct 18, 2020
@mhutchie mhutchie added this to To Do in Git Graph via automation Oct 18, 2020
@mhutchie
Copy link
Owner

Hi @AngheloAlf,

Thanks for raising this feature request, I definitely think this capability should be available in Git Graph! I’ll add it in an upcoming release.

@mhutchie mhutchie added this to the v1.28.0 milestone Nov 4, 2020
@mhutchie mhutchie moved this from To Do to In Progress in Git Graph Nov 4, 2020
@mhutchie
Copy link
Owner

mhutchie commented Nov 7, 2020

This will be available in v1.28.0.

I created two new extension settings (git-graph.repository.sign.commits and git-graph.repository.sign.tags) to control commit and tag signing respectively, instead of using the existing Visual Studio Code setting git.enableCommitSigning. This is because git.enableCommitSigning is specifically for signing commits, so some users may have found it misleading if it also meant Git Graph started signing tags. Although I could have just created a new setting for signing tags, and used git.enableCommitSigning for signing commits, this would have meant users would have to enable two completely separated settings in the Visual Studio Code Settings Editor. I think creating two new settings (grouped together) was ultimately the best solution, even though it would have been nice to share the same setting as the Visual Studio Code Git Extension.

If you'd like to use it before the next release, you can download v1.28.0-beta.0, and install it following the instructions provided here.

@mhutchie mhutchie closed this as completed Nov 7, 2020
Git Graph automation moved this from In Progress to Ready For Release Nov 7, 2020
@mhutchie mhutchie moved this from Ready For Release to Released in Git Graph Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
Git Graph
Released
Development

No branches or pull requests

2 participants