Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "Git Graph: File Encoding" Extension Setting to be Workspace Folder Scoped #416

Closed
tksmtd opened this issue Nov 15, 2020 · 3 comments
Assignees
Labels
feature request Feature request
Projects
Milestone

Comments

@tksmtd
Copy link

tksmtd commented Nov 15, 2020

We have multiple projects. Users and Workspace have similar settings.
Please give the same setting items to the vscode folder setting.
Please for users with multiple encoding.

Git-graph is the easiest change-history tool to use.
Thank you as always.

@tksmtd tksmtd added the feature request Feature request label Nov 15, 2020
@mhutchie
Copy link
Owner

Hi @tksmtd,

Thanks for raising this feature request!

There is a fairly significant amount of overhead and work required in order to have all extension settings scoped to a folder level, so up until now I’ve avoided it as no user had previously raised a scenario where the workspace scoped settings weren’t enough. In saying that, for many settings it’s easy to enable folder scoped settings (included “Git Graph: File Encoding”), just not all settings. I’ll work through the extension settings and enable as many of them to be folder scoped as possible. It seems this the approach taken by many other Visual Studio Code settings for the same reason.

Would you please provide a list of any other settings you need to have folder scoped, so I can ensure all of these are included in the subset I implement?

@mhutchie mhutchie added this to To Do in Git Graph via automation Nov 15, 2020
@mhutchie mhutchie moved this from To Do to In Progress in Git Graph Nov 18, 2020
@mhutchie mhutchie added this to the v1.28.0 milestone Nov 18, 2020
mhutchie added a commit that referenced this issue Nov 19, 2020
@mhutchie mhutchie changed the title Want 'Git-graph: File Encoding' to VSCode Folder Setting Enable "Git Graph: File Encoding" Extension Setting to be Workspace Folder Scoped Nov 19, 2020
@mhutchie
Copy link
Owner

I've implemented this change for the "Git Graph: File Encoding" extension setting, but have left other extension settings with their current scopes for now (after I did an initial review to determine suitability). I'd be happy to enable other extension settings to be Workspace Folder Scoped on a case-by-case basis.

This will be available in v1.28.0.

If you'd like to use it before the next release, you can download v1.28.0-beta.2, and install it following the instructions provided here.

Git Graph automation moved this from In Progress to Ready For Release Nov 19, 2020
@tksmtd
Copy link
Author

tksmtd commented Nov 19, 2020

Thank you so much! Now we can include multiple projects with multiple encodings.
I'm sorry for being busy and late in replying. However, a very quick update. Thank you!
I confirmed the operation earlier by v.1.28.0-beta.2. People who suffer from many encodings will be saved.
I always cheer for you.

@mhutchie mhutchie moved this from Ready For Release to Released in Git Graph Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
Git Graph
Released
Development

No branches or pull requests

2 participants