Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show commit date as well #42

Closed
JM-Mendez opened this issue Apr 1, 2019 · 6 comments
Closed

Show commit date as well #42

JM-Mendez opened this issue Apr 1, 2019 · 6 comments
Assignees
Labels
feature request Feature request
Projects
Milestone

Comments

@JM-Mendez
Copy link

Describe the feature that you'd like
A column that shows commit date rather than or adjacent to author date

Additional context (optional)

When running git log without filter options, eg "--since", git will show the author date. But when using said options or using git bisect it will use the commit date. Yet the commit date is not necessarily the same as the author date.

This discrepancy can manifest itself in various ways, but most commonly when rebasing branches. One situation in particular is running CI package updates and rebasing on develop to bring the current branch up to date.

I propose adding the %ct placeholder to assist when running commands like git bisect or filtering commits by date.

I'm willing to make a pull request if you'd like. Just point me on where to look.

@JM-Mendez JM-Mendez added the feature request Feature request label Apr 1, 2019
@mhutchie
Copy link
Owner

mhutchie commented Apr 1, 2019

Thanks for the feedback, this is a great suggestion!

It's a really quick change, I can do it.

I think it would be best to add a new setting which determines which date is shown in the table and commit details view. Then the user can choose their preference of author or commit date. What are your thoughts on this?

@mhutchie mhutchie added this to the v1.4.4 milestone Apr 1, 2019
@mhutchie mhutchie added this to To Do in Git Graph Apr 1, 2019
@JM-Mendez
Copy link
Author

Wow, you're amazing! Thank you. Yeah I personally prefer to choose myself, rather than having an extra column taking up space.

@mhutchie mhutchie moved this from To Do to In Progress in Git Graph Apr 1, 2019
mhutchie added a commit that referenced this issue Apr 1, 2019
@mhutchie mhutchie moved this from In Progress to Ready For Release in Git Graph Apr 1, 2019
@mhutchie
Copy link
Owner

mhutchie commented Apr 1, 2019

This will be available in 1.4.4, which will be released within the next day.

@mhutchie mhutchie closed this as completed Apr 1, 2019
@mhutchie mhutchie moved this from Ready For Release to Released in Git Graph Apr 1, 2019
@cateyes99
Copy link

cateyes99 commented Feb 26, 2020

@mhutchie Can you please make an option to show both author date and commit date at the same time? I have a commit:

* commit b3ddb2dc6ccdd338111205f2cee3bb204694ebbf (origin/Release_Branches/20-02-2020)
| Author:     Someone
| AuthorDate: Thu Feb 13 02:09:45 2020 +0000
| Commit:     Sometwo
| CommitDate: Wed Feb 19 13:27:17 2020 +1300
|
|     Merged PR 12850: increased callback limit from 1 to 3
|
|     Increased callback limit from 1 to 3
|
|     As agreed in meeting 31/1/2020
|
|     Related work items: #16897

In Git Graph, it shows either author date as date or commit date as date depending on the date type settings. Below is with the default setting - showing author date
image

@mhutchie
Copy link
Owner

@cateyes99 I'll add this in an upcoming release, now need to raise a feature request as it’s small and easy for me to do.

@cateyes99
Copy link

@cateyes99 I'll add this in an upcoming release, now need to raise a feature request as it’s small and easy for me to do.

Done. I've created #269.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
Git Graph
Released
Development

No branches or pull requests

3 participants