-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSB stream reader's fill_value
doesn't do anything
#105
Comments
@cczhu - but GSB can have missing data blocks, which would be noticed from the timestamp file. Still, since currently we do not do anything with it, I guess we might as well remove it for now. |
@mhvk that's true, but since payload-timestamp connections are inferred rather than embedded within the GSB file, is it even safe to keep reading after hitting a missing timestamp? It could be that the payload kept writing, or was partly written. I suppose we could do a complete file integrity check at the beginning to make sure the payload file sizes add up to the number of header lines, and then assume missing data only if everything does check out (which still leaves the possibility for some forms of time offsets to go unchecked)? |
"Needs clarification" since I think there is a decision to be made here: my current sense is that |
fixed by #163 (by removing the |
Following on #101,
fill_value
in GSB doesn't do anything. This makes sense since GSB has no built-in way to flag for invalid data. I'm not sure why the option even exists, though - should we just get rid of it?The text was updated successfully, but these errors were encountered: