Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress Visual Regression Tests for remaining components (delete loki screenshots) #1891

Closed
9 tasks done
GCHQ-Developer-299 opened this issue May 21, 2024 · 2 comments
Closed
9 tasks done
Assignees
Milestone

Comments

@GCHQ-Developer-299
Copy link
Contributor

GCHQ-Developer-299 commented May 21, 2024

Summary

We've still got a number of components using Loki for their reference images - these need to be migrated to Cypress visual regression tests that use compareSnapshot()

  • Radio [ic-radio-option\ic-radio-group] - Cypress Migration #1794
  • Search Bar
  • Select (no Loki screenshots left but apparently still needs all cypress tests)
  • Status Tag (no cypress tests currently present - full migration required?)
  • Stepper (no cypress tests currently present - full migration required?)
  • Switch
  • Tabs (just need to delete old screenshots, new vr tests already exist)
  • Tooltip (no cypress tests currently present - full migration required?)
  • Typography (no cypress tests currently present - full migration required?)

💬 Description

Replicate current loki screenshots (see reference folder ) in cypress for relevant components above. Can be in multiple pull requests for convenience.

Also add High Contrast screenshots for each one (see TextField)

if focus states are captured in the screenshots, it should ensure that all the focus indicator is visible

@gd2910
Copy link
Contributor

gd2910 commented Jun 12, 2024

All tests should pass first time locally (retries: 0)
All test thresholds should be set 0.1 above the difference
DEFAULT_TEST_THRESHOLD should be set referencing the lowest passing visual regression test
Visual regression tests should be separated from e2e tests

@MI6-255
Copy link
Contributor

MI6-255 commented Jun 12, 2024

PR per component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants