Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ic-side-navigation] escape doesn't close the menu on mobile top bar #1921

Open
GCHQ-Developer-530 opened this issue May 24, 2024 · 2 comments
Labels
type: bug 🐛 Something isn't working

Comments

@GCHQ-Developer-530
Copy link
Contributor

Summary of the bug

When you view side nav on a small device and open up the menu, pressing escape doesn't close the menu.

You can currently close the menu by hitting enter/space or clicking close, but I feel this should also be added in as another method of closing the menu.

🪜 How to reproduce

Tell us the steps to reproduce the problem:

  1. Go to any side nav example
  2. Reduce screen size so that the top bar behaviour shows
  3. Open up the menu
  4. Try to escape and see the error

🧐 Expected behaviour

Pressing escape should close the menu.

@MI6-255
Copy link
Contributor

MI6-255 commented Jul 3, 2024

Good practice, not a violation

@MI6-255 MI6-255 added this to the Future Release milestone Jul 3, 2024
@MI6-255 MI6-255 added the good first issue A good starter issue if you haven't contributed to the ICDS before label Jul 3, 2024
@MI6-255
Copy link
Contributor

MI6-255 commented Jul 11, 2024

Is there a complication if you press escape when focused on another element e.g. a form, we wouldn't want it to close the side navigation?

@MI6-255 MI6-255 removed the good first issue A good starter issue if you haven't contributed to the ICDS before label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Status: Ready for dev
Development

No branches or pull requests

2 participants