1906 data table slotted content #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1906-data-table-slotted-content/web-components |
ad9242
force-pushed
the
1906-data-table-slotted-content
branch
from
2468ee7
to
31ca22f
Compare
|
Cypress visual tests failed. |
fixes issue where slot content would return as null, even though content was in the slot
… in data table cell fixes issue where SlottedSVG in a table cell prevented the data able from rendering
ad9242
force-pushed
the
1906-data-table-slotted-content
branch
3 times, most recently
from
027ccaf
to
78f1e47
Compare
adds a test to handle when a SlottedSVG is placed in the table cell
ad9242
force-pushed
the
1906-data-table-slotted-content
branch
from
78f1e47
to
75520f1
Compare
GCHQ-Developer-465
approved these changes
May 28, 2024
gd2910
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Fixes an issue with slotting content into data-table cells. In some cases the check for content in the slot would return null. For example, if using a
<SlottedSVG>elementThe change to the
getSlotElementshelper method means some code can be removed from ic-horizontal-scroll, as the slot content will now be returned by that methodRelated issue
#1906
Checklist
Testing