Propagate flask_rest_jsonapi errors to flask #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I support this change. It gives users the option to fully customize the error handling. Not all users will be happy with the particular error handling that is enforced otherwise. |
Use get function to prevent KeyError when PROPAGATE_EXCEPTIONS is not set Co-Authored-By: Areeb Jamal <jamal.areeb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
ROPAGATE_EXCEPTIONSis set, it is desirable to re-throw the error such that any registered flask error handlers will take care of it.This fixes the error described in issue #162.