Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make @types/node a devDependency #227

Closed
wants to merge 3 commits into from
Closed

Make @types/node a devDependency #227

wants to merge 3 commits into from

Conversation

GioAc96
Copy link

@GioAc96 GioAc96 commented May 12, 2022

Changes

  • Make @types/node a devDependency instead of a normal dependency

@coveralls
Copy link

coveralls commented May 12, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 97.463% when pulling ed803c6 on fix/types-node-dev-dependency into eb26555 on master.

ilteoood
ilteoood reviewed May 12, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@davidebianchi
Copy link
Member

Is this PR correct? The @types/node dependency is used in index.d.ts, which is exported. This change could break the export of this types?

@GioAc96
Copy link
Author

GioAc96 commented May 13, 2022

@davidebianchi you're probably correct (see link below). Closing the PR:

https://stackoverflow.com/questions/45176661/how-do-i-decide-whether-types-goes-into-dependencies-or-devdependencies

@GioAc96 GioAc96 closed this May 13, 2022
@davidebianchi davidebianchi deleted the fix/types-node-dev-dependency branch May 13, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilteoood ilteoood ilteoood left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GioAc96 @coveralls @davidebianchi @ilteoood