Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing generics to HttpClient methods #238

Merged
merged 1 commit into from
Jun 25, 2022
Merged

fix: add missing generics to HttpClient methods #238

merged 1 commit into from
Jun 25, 2022

Conversation

malta895
Copy link
Member

@malta895 malta895 commented Jun 8, 2022

Checklist

  • your branch will not cause merge conflict with master
  • run npm test
  • tests are included
  • the documentation is updated or integrated accordingly with your changes
  • the code will follow the lint rules and style of the project
  • you are not committing extraneous files or sensible data

@malta895 malta895 marked this pull request as ready for review June 8, 2022 14:17
@coveralls
Copy link

coveralls commented Jun 8, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 97.627% when pulling 94f741b on fix/http-client-missing-generics into 552deda on master.

@epessina
Copy link
Contributor

Ping

@davidebianchi davidebianchi merged commit bd03a01 into master Jun 25, 2022
@davidebianchi davidebianchi deleted the fix/http-client-missing-generics branch June 25, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidebianchi davidebianchi Awaiting requested review from davidebianchi

@ilteoood ilteoood Awaiting requested review from ilteoood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@malta895 @coveralls @epessina @davidebianchi