Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefix option to service builder #3

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Add prefix option to service builder #3

merged 2 commits into from
Aug 23, 2018

Conversation

allevo
Copy link
Contributor

@allevo allevo commented Aug 23, 2018

as titled

@allevo allevo requested a review from PaoloSarti August 23, 2018 10:44
@coveralls
Copy link

coveralls commented Aug 23, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 17

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 96.8%
Totals Coverage Status
Change from base Build 15: 0.04%
Covered Lines: 269
Relevant Lines: 269
💛 - Coveralls

PaoloSarti
PaoloSarti approved these changes Aug 23, 2018
View reviewed changes
Copy link

@PaoloSarti PaoloSarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allevo allevo merged commit 8cbeac9 into master Aug 23, 2018
@allevo allevo deleted the add-prefix branch August 23, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaoloSarti PaoloSarti PaoloSarti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@allevo @coveralls @PaoloSarti