Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix required env var with default #309

Merged
merged 5 commits into from
Nov 24, 2022
Merged

Fix required env var with default #309

merged 5 commits into from
Nov 24, 2022

Conversation

davidebianchi
Copy link
Member

Checklist

  • your branch will not cause merge conflict with master
  • run npm test
  • tests are included
  • the documentation is updated or integrated accordingly with your changes
  • the code will follow the lint rules and style of the project
  • you are not committing extraneous files or sensible data

@davidebianchi davidebianchi added the bug Something isn't working label Nov 24, 2022
@davidebianchi davidebianchi changed the title fix: fix required env var with default Fix required env var with default Nov 24, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 94.828% when pulling 5087cb6 on fix/default-required-env-var into b443bfd on master.

@coveralls
Copy link

coveralls commented Nov 24, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 94.828% when pulling 7498592 on fix/default-required-env-var into b443bfd on master.

ianFar96
ianFar96 reviewed Nov 24, 2022
View reviewed changes
index.js Outdated Show resolved Hide resolved
ianFar96
ianFar96 reviewed Nov 24, 2022
View reviewed changes
index.js Outdated Show resolved Hide resolved
davidebianchi and others added 3 commits November 24, 2022 12:46
@davidebianchi @ianFar96
Update index.js
be219ee 
Co-authored-by: Ian Farré <30315670+ianFar96@users.noreply.github.com>
@davidebianchi @ianFar96
Update index.js
d3b9eaa 
Co-authored-by: Ian Farré <30315670+ianFar96@users.noreply.github.com>
@davidebianchi
fix
7498592
@davidebianchi davidebianchi merged commit 6a2d33e into master Nov 24, 2022
@davidebianchi davidebianchi deleted the fix/default-required-env-var branch November 24, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianFar96 ianFar96 ianFar96 left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidebianchi @coveralls @ianFar96