Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bot error message handling #7

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fix bot error message handling #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 12 additions & 1 deletion sucks/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,15 @@
'dust_case_heap': COMPONENT_FILTER
}

ERROR_CODES = {
"100": "Robot is operational",
"101": "Low battery",
"102": "Robot is stuck",
"103": "Wheels are not moving as expected",
"104": "Down sensor is getting abnormal values",
"110": "Dust Bin Not installed",
}

class EcoVacsAPI:
CLIENT_KEY = "eJUWrzRv34qFSaYk"
SECRET = "Cyu5jcR4zyK6QEPn1hdIGXB5QIDAQABMA0GC"
Expand Down Expand Up @@ -289,7 +298,9 @@ def _handle_ctl(self, ctl):
getattr(self, method)(ctl)

def _handle_error(self, event):
error = event['error']
errno = event.get('errno')
if not errno or (error := ERROR_CODES.get(errno)) is None:
error = event.get('error', 'unknown')
self.errorEvents.notify(error)
_LOGGER.debug("*** error = " + error)

Expand Down
10 changes: 10 additions & 0 deletions tests/test_vacbot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,16 @@ def test_error_event_subscription():
v._handle_ctl({"event": "error", "error": "an_error_name"})
mock.assert_called_once_with("an_error_name")

for err_code, err_msg in ERROR_CODES.items():
v._handle_ctl({"event": "error", "errno": err_code})
mock.assert_called_with(err_msg)

v._handle_ctl({"event": "error", "errno": "999"})
mock.assert_called_with("unknown")

v._handle_ctl({"event": "error"})
mock.assert_called_with("unknown")

# Test unsubscribe
mock = Mock()
subscription = v.errorEvents.subscribe(mock)
Expand Down