Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using aiohttp built-in timeouts #300

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Switch to using aiohttp built-in timeouts #300

merged 3 commits into from
Apr 12, 2024

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Apr 11, 2024 •
edited

Drops async_timeout and let aiohttp handle the timeout

@bdraco bdraco marked this pull request as ready for review April 11, 2024 23:22
@bdraco bdraco requested a review from mib1185 as a code owner April 11, 2024 23:22
mib1185
mib1185 requested changes Apr 12, 2024
View reviewed changes
src/synology_dsm/synology_dsm.py Outdated Show resolved Hide resolved
mib1185
mib1185 previously approved these changes Apr 12, 2024
View reviewed changes
Copy link
Owner

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thx @bdraco 👍

@mib1185 mib1185 merged commit 2f7df3b into mib1185:master Apr 12, 2024
6 checks passed
@mib1185 mib1185 added the enhancement PR that adds new feature label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mib1185 mib1185 mib1185 approved these changes

Assignees
No one assigned
Labels
enhancement PR that adds new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bdraco @mib1185