Fixed a few Clippy warnings

mibes · Nov 15, 2023 · ab2a765 · ab2a765
1 parent 9217d2e
commit ab2a765
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/couch_rs/src/client.rs b/couch_rs/src/client.rs
@@ -95,6 +95,9 @@ impl Client {
     /// new_with_timeout creates a new Couch client. The URI has to be in this format: http://hostname:5984,
     /// The timeout is applied from when the request starts connecting until the response body has finished.
     /// Timeout is in seconds.
+    ///
+    /// # Panics
+    /// Panics when the AUTHORIZATION header can not be set on the request.
     pub fn new_with_timeout(
         uri: &str,
         username: Option<&str>,

diff --git a/couch_rs/src/database.rs b/couch_rs/src/database.rs
@@ -1097,6 +1097,9 @@ impl Database {
     ///     Ok(())
     /// }
     /// ```
+    ///
+    /// # Panics
+    /// When the internal json! macro fails to create a json object. Not expected to happen.
     pub async fn insert_index(
         &self,
         name: &str,
@@ -1215,15 +1218,15 @@ fn get_mandatory_string_value(key: &str, value: &Value) -> CouchResult<String> {
 
 fn to_create_value(doc: &impl TypedCouchDocument) -> CouchResult<serde_json::Map<String, Value>> {
     let mut value = get_value_map(doc)?;
-    set_if_not_empty(ID_FIELD, doc.get_id().to_string(), &mut value);
+    set_if_not_empty(ID_FIELD, doc.get_id().as_ref(), &mut value);
     value.remove(REV_FIELD);
     Ok(value)
 }
 
 fn to_upsert_value(doc: &impl TypedCouchDocument) -> CouchResult<serde_json::Map<String, Value>> {
     let mut value = get_value_map(doc)?;
-    set_if_not_empty(ID_FIELD, doc.get_id().to_string(), &mut value);
-    set_if_not_empty(REV_FIELD, doc.get_rev().to_string(), &mut value);
+    set_if_not_empty(ID_FIELD, doc.get_id().as_ref(), &mut value);
+    set_if_not_empty(REV_FIELD, doc.get_rev().as_ref(), &mut value);
     Ok(value)
 }
 
@@ -1240,7 +1243,7 @@ fn get_value_map(doc: &impl TypedCouchDocument) -> CouchResult<serde_json::Map<S
     Ok(value)
 }
 
-fn set_if_not_empty(field_name: &str, field_value: String, value: &mut serde_json::Map<String, Value>) {
+fn set_if_not_empty(field_name: &str, field_value: &str, value: &mut serde_json::Map<String, Value>) {
     if field_value.is_empty() {
         value.remove(field_name);
     } else {

diff --git a/couch_rs_derive/Cargo.toml b/couch_rs_derive/Cargo.toml
@@ -17,6 +17,6 @@ name = "couch_rs_derive"
 proc-macro = true
 
 [dependencies]
-proc-macro2 = ">1.0.66"
+proc-macro2 = "^1.0.66"
 quote = "1.0"
 syn = { version = "2.0", features = ["visit"] }