Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Publish artefacts for new version 1.9.8/1.9.9 to maven central #71

Open
sylvainlaurent opened this issue Feb 2, 2018 · 5 comments
Open

Comments

@sylvainlaurent
Copy link

when I run the DSL with plugin 1.9.8 I see some deprecation warnings in the logs of the bamboo job.

But I don't see them in IntelliJ if I set the dependency to version 1.9.7.
I tried to upgrade to 1.9.8 but the artefacts are not on maven central...

@mrueegg
Copy link
Contributor

mrueegg commented Feb 2, 2018

Hi,

1.9.8 and 1.9.9 were both releases that targeted the Bamboo plug-in only. No changes were necessary for the DSL part, so we didn't publish a new library for them. But I think we will do this anyway in the future to be always in sync between the plug-in and DSL versions.

Could you please show me the deprecations you got with 1.9.8 compared to 1.9.7 in IntelliJ? That would help me much. Thanks

@sylvainlaurent
Copy link
Author

I have warnings in bamboo like these:

simple	01-Feb-2018 09:54:04	Plan DSL: warning: (build_plans.groovy:137): scheduled is deprecated
simple	01-Feb-2018 09:54:04	Plan DSL: warning: (build_plans.groovy:168): watchers is deprecated

but when I look at the source code of ch.mibex.bamboo.plandsl.dsl.triggers.Triggers#scheduled(groovy.lang.Closure) (see

void scheduled(@DelegatesTo(value = ScheduledTrigger, strategy = Closure.DELEGATE_FIRST) Closure closure) {
) it's not marked as deprecated...

it would be nice if both warnings were aligned because it's much easier to do it in the IDE!�

@mrueegg
Copy link
Contributor

mrueegg commented Feb 8, 2018

Hi @sylvainlaurent

Both methods are deprecated if they are used with a description (scheduled) or an event (watchers). Here's an example:

triggers {
            scheduled("test") {
                
            }
}

Intellij marks this as deprecated. Which method overload of scheduled and watchers are you using?

@sylvainlaurent
Copy link
Author

Hello @mrueegg ,
the trigger is declared like this:

            triggers {
                bitbucketServerRepositoryTriggered {}
                scheduled() {
                    description('every week')
                    cronExpression('0 0 23 ? * WED')
                }
            }

@mrueegg
Copy link
Contributor

mrueegg commented Feb 11, 2018

@sylvainlaurent Thanks a lot for the example. I was able to reproduce it. Will now try to solve this and get back to you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants