Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features some optimizations that make values more compact.
A big bottleneck right now is the amount of destructors that kill branch prediction. I did some optimizations in places where the type of the value is known (namely, number operations) and
std::mem::forget
is called there to not run destructors when we know that the type of a value does not need any special work.Here's a comparison between having a
impl Drop for ValueImpl
and not having it:Of course the faster version does not clean up any memory, which is bad.
With that I conclude that Mica needs garbage collection for improved performance.