-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to compose syntax for volumes_from
, volumes
, and optional cpu
parameter
#42
Fixes to compose syntax for volumes_from
, volumes
, and optional cpu
parameter
#42
Conversation
* The `cpu` parameter in ECS is now optional. I think it was required before. So we don't emit an error message when it's not present. * Allow the compose v2 style 'service:name:ro' syntax in `volumes_from` clauses. * Emit `readOnly` on ECS `volumesFrom` clauses, which were previously skipped.
Love it! 👍 |
volumes_from
& make cpu
optional.volumes_from
, volumes
, and optional cpu
parameter
parts = vol.split(':') | ||
rwo_value = None | ||
|
||
assert(len(parts) <= 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an explanation parameter to this assert so the error is a little more clear? ``assert(len(parts) <=3, "volume string '{}' has too many colons".format(vol))` or something like that?
This is great! Thanks for submitting. Just one comment on the compose |
@philipn Any chance you could fix the indentation for the failing CI? |
any blockers for this to be merged? |
cpu
parameter in ECS is now optional. I think it was required before. So we don't emit an error message when it's not present.volumes_from
clauses.volumes
clauses.readOnly
on ECSvolumesFrom
clauses, which were previously skipped.