Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory is an integer - v1.1.6 #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kplimack
Copy link

@kplimack kplimack commented Mar 14, 2018

  • Memory is an integer, not a float.
  • Deployment should use apiVersion: apps/v1
  File "/usr/local/lib/python3.6/site-packages/container_transform-1.1.5-py3.6.egg/container_transform/marathon.py", line 282, in ingest_memory
    return memory << 20
TypeError: unsupported operand type(s) for <<: 'float' and 'int'

Signed-off-by: Jake Plimack jake.plimack@gmail.com

Signed-off-by: Jake Plimack <jake.plimack@gmail.com>
@kplimack
Copy link
Author

kplimack commented Mar 14, 2018

@micahhausler can you help me fix this build. test coverage as a metric is awful and i'm not inclined to help you chase 100%

TOTAL                                 1153    170    492      0    84%
nose.plugins.cover: ERROR: TOTAL Coverage did not reach minimum required: 100%
The command "python setup.py nosetests" exited with 1.

Signed-off-by: Jake Plimack <jake.plimack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant