Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for compose port range syntax #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ConnorAtherton
Copy link

Before I get to the PR: we are currently in the process of switching all of our current descriptors over to other things in order to test out a new cluster internally, and this tool has already provided a lot of value for us. Thanks for all the work this far. It's a small thing, but it's already saved us so much time in the early going.

Issue

Currently, container-transform will throw an error when trying to map ingress ports like 9090-9091:8080-8081 in a docker-compose file.

Additions

This PR fixes that case by checking if the port mapping contains the dash character, and handling it appropriately. It also adds support for the other port ranges on the docker-compose v2 docs here with the exception of port ranges that also include the host. If you want that included too, I can make that happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant