Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to third person on rocket launch isn't nice in vivecraft #2405

Closed
Rami-Pastrami opened this issue Feb 22, 2017 · 6 comments
Closed

switch to third person on rocket launch isn't nice in vivecraft #2405

Rami-Pastrami opened this issue Feb 22, 2017 · 6 comments
Labels

Comments

@Rami-Pastrami
Copy link

Hi.

I am using a minecraft mod known as "vivecraft" which allows minecraft to be played in VR with room tracking.

This mod, over all, works great. However, when getting in and out of rockets/landers/etc, the view may jump from 1st person to third, which is extremely nauseating and is really the only major bug this other wise great mod has with VR.

I think the best possible fix for this issue is to have a config option to disable all 3rd person jumps, and remain in first person at all times.

Thank you!

@radfast
Copy link
Collaborator

radfast commented Feb 25, 2017

The jump from 1st person to third is intentional.

We can maybe look at a config option here, though I've never heard of anyone else playing GC in VR. How many downloads does vivecraft have?

@radfast radfast changed the title third person bugging out in vivecraft switch to third person on rocket launch isn't nice in vivecraft Feb 25, 2017
@Rami-Pastrami
Copy link
Author

http://www.vivecraft.org/

I couldnt find any numbers but it is certainly under development actively with a considerable following.
I would like to note that 1.7.10 is the only current version with forge mod support. I believe later versions of vivecraft will be getting forge support later (it was mentioned a few times on forums)

@Brycey92
Copy link
Contributor

Brycey92 commented Feb 25, 2017

My PR #2410 should automatically check if Vivecraft is installed and disable third-person switching if so. If someone could test it, that would be awesome!

Also, I would like to find a way to check whether the Vive is being used or not, since Vivecraft can be installed without requiring the use of the Vive. If my current solution works, I'll see if Vivecraft offers an API or something.

@radfast
Copy link
Collaborator

radfast commented Feb 25, 2017

Thank you to @Brycey92 for finding a solution so fast, great job
We should be able to fix this today or tomorrow. I've made some comments on #2410

@Brycey92
Copy link
Contributor

@doggogoesbork I implemented a config option in #2412 to disable camera changes in vehicles, and radfast merged it. If you can compile and build everything, let us know how it goes in VR. If you can't compile (and radfast doesn't object) I can give you compiled jars from my workspace.

@radfast
Copy link
Collaborator

radfast commented Feb 25, 2017

thank you @Brycey92, great job

I will make a new GC build 466 now with this, and other recent fixes.
@doggogoesbork you can just test 466, please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants