[With Sponge] Occasional Mars spawn chunk errors #2975
Comments
|
Modlist? |
|
Guessing |
|
Yes, at info is also on the website too :P the version for sponge is correct, the forge version isn't. I plan on fixing it soon so that it properly represents everything on the server. |
|
Hi @hugeblank This appears to be a block ID issue during worldgen. It's likely not a Galacticraft issue at all, but caused by something else in your setup. Obviously, Galacticraft is using its own correct block IDs when generating Mars, and the rest of the planet confirms that. We can maybe look into this some more, but you will need to help by doing more extensive testing, as the issue is specific to your server.
|
|
This is an issue I am having as well. Its not any particular mod that has its blocks used either. It can be any number of mods that you have installed along side it. From what I have seen it happens regardless of what mods are installed however I have not tested them all individually yet, just in quarters. This affects DIM-33 and DIM-29 though possibly by chance as it has affected other galacticraft planets instead on rare occasions. Both sponge and forge are the latest. This also only happens to GalactiCraft dimensions. The corruption is not limited to one chunk but often spanning several 10s to 100s of chunks. This also is not a generation issue as well as it will be fine and then corrupt into what you see in that image after a restart or two and a unlogged shutdown error within forge clearly marked as an error in galacticraftcore. Labeling it as not a Galacticraft issue seems to be a bit premature in light of galacticraftcore being specifically named in the error that is the most likely candidate as the source given that the bug appears after a restart and so does that error. It is worth mentioning that the unloading of the nether is NOT the galacticraftcore error as when I include code to disable world unloading that error is gone but galacticraft-plaents and extraplanets still failed to receive their FMLServerStoppedEvent event because galacticraftcore errored on its FMLServerStoppedEvent event. Also there is world duplication of the nether, overworld, and end and it is caused by galacticraft as it only happens when galacticraft is installed, even by its self. The invisible error The code used to disable unloads (Not for production use as it nukes ids on restart) |
radfast
changed the title
The system is not always accurately marking which mod has errored, so this is fairly meaningless. I'm still having difficulty reproducing this error. I test Galacticraft myself on a Sponge 1.11.2 server, I've played through around 30 hours of gameplay and it is rock solid stable. Please can you show me the error relating to the FMLServerStoppedEvent event, maybe we can do something about that. |
|
Current theory is something else might be messing with duplicate dimension id's like the nether, and potentially crashing the save thread. |
|
@radfast Ok i have this problem on my private server, I have spent 10 hours or so debugging this, it seems that mars and dimension -33 dont seem to be saving, thats why blocks are changing as its corrupted chunks This is a list of the tests I've tried From these tests it seems that it breaks when i add any 5th planet, the 4 planets can be any 4 planets in my addon. The people over at SpongeForge discord have been helping me with this and can see how this is a issue and are confused as much as me. We really need your help @radfast with this |
|
@radfast Also it seems that when the server starts with spongeforge that the dimensions get re-registered |
|
I don't have any insight. SpongeForge adds many layers of code and complexity to standard Minecraft/Forge dimensions. I have no clue why ExtraPlanets adding 4 new planets (in addition to Galacticraft's standard 4 dimensions) is OK but 5 new planets breaks things. To troubleshoot this properly, you'd need to set up an IDE workspace with the full SpongeForge source code as well as Galacticraft source and Extra Planets, and then set breakpoints and watches. I personally have not succeeded to set up SpongeForge sources error-free (even without Galacticraft), and I don't have time to keep trying - maybe you can be smarter or luckier than me and you can get it to work? The |
|
Some things I would maybe look at if trying to guess quickly: dimension ID conflict, some kind of default size limit for a data structure related to the dimensions, or a time-out in the save process (e.g maybe another server tick happens while the map save is still ongoing). |
|
Thanks for the reply, im not sure how i can go about debugging this myself without the help of spongeforge and maybe yourself. After spending the 10 hours already on this issue, im not sure where to start with it if im honest, the fact that it works with forge confirms in my own head that my dimensions are registered correctly and the fact that me disabling different dimensions still causes the issue. The questions which im still confused over are: |
|
I will see what i can debug further myself and get back to you |
let me know what the exact issues are, clone spongeforge recursively run setupdecompworkspace like with any other mod see here |
|
Ok just ran a quick test with my local server that i made a while ago for my tests posted above, The tests are did are as followed: Im even more confused but doing more debuging now |
|
Just tried changing phobos id to -105: and phobos saves now but mars doesnt still |
|
It seems if i change anyone of the dimensions from -29 for mars and -33 for phobos that dimension works But only one and not both if i change both |
|
1.10.2-2477-5.2.0-BETA-2635 or 1.10.2-2477-5.2.0-BETA-2637 wasnt able to test 1.10.2-2477-5.2.0-BETA-2635 as it didnt even start the server just errored out 1.10.2-2477-5.2.0-BETA-2632 and back works i wasnt able to find a stable version before build 2632 that worked for everything but this issue so i cant change back to one without bring more issues to the table Atm im debugging with changing stuff from forge mods side but atm i think this isnt the place i should be looking and its in the spongeforge code i should be looking |
|
i think the problem is there two nethers and two ends, but no mars and phobos |
|
And seems to be linked to the issue fixed by SpongePowered/SpongeForge@debfb39 |
|
hey @MJRLegends I'm closing this as I don't think the issue is on GC's side, but I am still monitoring the discussion here.
This is a possible concern. Bear in mind that the dimension ID in the config is used for both the WorldProvider type ID and the actual Forge dimension number. It's also possible that the folder name DIM-29 is always used for Mars even if the dimension ID changes - it's only a name. It would be interesting to look at what happens with the same setup without Sponge. I do not have time to troubleshoot Sponge dimension issues. They can quite easily occur, because Sponge adds a lot of different dimension handling which is aimed at multiverse plugin type dimensions (extra server spawn dimensions etc) but not originally coded with Forge dimensions in mind. Sponge has internal data structures for dimensions which are not even accessible from Forge mods, which is a huge PITA. In addition Sponge creates a Sponge config file for each of your dimensions. Bear in mind that if you are changing dimension things on Galacticraft's side, you might still be using an old version of the Sponge config file for that dimension, and that might mess with some of your GC changes. I don't remember the exact issues I had with trying to integrate Sponge with my Galacticraft development environment for debugging Sponge, but I spent a full day on it without success. I suggest you try it yourself, you might not encounter the same issues if I don't "poison" your attempt by telling you what I did... |
Minecraft version: 1.11.2
Galacticraft version: 117
Forge version: 13.20.1.2454
Single player (SSP) or Multiplayer (SMP)?
SMP
Galacticraft add-ons and other mods installed?
ExtraPlanets
Please provide screenshots / crash report / log as needed.
The issue:
Well... as can be seen by the screen cap, this is definitely not mars. It seems to be generating the spawn chunks using the Tinkers' construct slab blocks. It looks to be a roughly 16x16 chunk area that's bugged out this way. I've tried on three different instances to delete the dimension and it regenerates this way.
The text was updated successfully, but these errors were encountered: