feature: load plugins relative to the current working directory #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
/cc @michael-ciniawsky can't wait to have this 😄 |
Scrum
approved these changes
Feb 15, 2018
| try { | ||
| return require(resolveFrom(cwd, plugin)) | ||
| } catch (_err) {} | ||
|
|
There was a problem hiding this comment.
it seems to me flatry will be appropriate here
There was a problem hiding this comment.
Didn't want to add an extra dependency ;-)
| @@ -2,19 +2,22 @@ | |||
| "name": "postcss-load-plugins", | |||
| "version": "2.3.0", | |||
| "description": "Autoload Plugins for PostCSS", | |||
| "engines": { "node": ">=0.12" }, | |||
| "engines": { | |||
| "node": ">=0.12" | |||
|
@gitscrum @michael-ciniawsky let's get this merged? |
|
@michael-ciniawsky I need access from npm to publish this |
|
@michael-ciniawsky ping |
1 similar comment
|
@michael-ciniawsky ping |
|
@Scrum @michael-ciniawsky ping |
|
@l5x sorry, I still do not have access. |
|
@l5x This is supported in |
michael-ciniawsky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In the spirit zero configuration (#0CJS) trend postcss-load-plugins should be able to require plugins relative to the
ctx.cwd.Closes #42
Types of changes
Bug (non-breaking change which fixes an issue)Breaking Change (fix or feature which changes existing functionality)Checklist
I have added necessary documentation (if appropriate)Any dependent changes are merged and published in downstream modulesReviewers: @michael-ciniawsky, ...