Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add ability to manage subscriptions #379

Closed
wants to merge 4 commits into from

Conversation

woorst
Copy link
Contributor

@woorst woorst commented Jun 11, 2017

Addressing issues #363 #193.

This is not quite ready to merge. Right now you can:

  • subscribe to a subreddit (press / while in the subscription page)
  • unsubscribe to a subreddit (press d while in subscription page)
  • create a multireddit (press / while in the multireddit page)
  • delete a multireddit (press d while in the multireddit page)
  • view contents of a multireddit (press space while in multireddit page)

Problems:

  • I'm getting some sort of authentication error whenever I try to add/remove a subreddit from a multireddit
  • listing the contents a multireddit is very slow. Much slower than actually opening multireddit
  • because you can't view an empty page in rtv, you can't navigate to a newly created multireddit and add subreddits to it
  • idk what modhash is. I had to do a little hack to get that to work
  • do you think there should be a confirmation dialog before deleting an entire multireddit?

@michael-lazar
Copy link
Owner

Thanks, I've been a little busy lately but I'll checkout the branch and try it out when I get a chance

  • listing the contents a multireddit is very slow. Much slower than actually opening multireddit

You should check the rtv log and see which API requests are actually being made. Probably, the API call that returns the subreddits in a multireddit doesn't return all of the properties that the subscription page uses to draw the page. So PRAW silently makes a separate API request for each subreddit to fill in the missing properties.

-because you can't view an empty page in rtv, you can't navigate to a newly created multireddit and add subreddits to it

Hmm yea I can't think of a good solution for this off the top of my head

  • idk what modhash is. I had to do a little hack to get that to work

https://www.reddit.com/dev/api/ says that it's for CSRF protection, but that it isn't required when using OAuth credentials so it sounds like it's deprecated. We might just want to set it to an empty string when praw is initialized and see if that breaks anything else.

  • do you think there should be a confirmation dialog before deleting an entire multireddit?

I think that sounds reasonable, anytime something is deleted there should be a confirmation dialog.

@woorst woorst closed this Jul 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants