Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove completed courses in {mycoursesmenu} #114

Closed
argwallace opened this issue Aug 20, 2020 · 15 comments
Closed

Remove completed courses in {mycoursesmenu} #114

argwallace opened this issue Aug 20, 2020 · 15 comments
Assignees
Labels
feature request New features, enhancements

Comments

@argwallace
Copy link

Hello!

I am using the most current version (2.0.0) of FilterCodes on Moodle 3.8.4. I have a custom navigation menu that is working just fine in my theme with the {mycoursemenu} tag. However, I have noticed that when a course is completed, it will be removed from the side navigation area under My Courses but it still remains in the filtercodes {mycoursesmenu}. Any way to resolve this as it gives conflicting results. Thanks!
Stephen

@michael-milette
Copy link
Owner

Hi Stephen,

That is a good point and a great idea. Probably makes a lot of sense to remove the completed courses, especially if your students tend to take a lot of courses like in a school (I work mostly with businesses, non-profits and go government). Definitely going to look into this for a future release.

Best regards,

Michael

@michael-milette michael-milette added the feature request New features, enhancements label Sep 24, 2020
@michael-milette michael-milette changed the title Error with {mycoursemenu} Removd completed courses in {mycoursemenu} Sep 24, 2020
@argwallace
Copy link
Author

argwallace commented Sep 28, 2020 via email

@michael-milette michael-milette added the hacktoberfest Contributions qualify for Digital Ocean Hacktoberfest label Oct 5, 2020
@michael-milette michael-milette changed the title Removd completed courses in {mycoursemenu} Remove completed courses in {mycoursemenu} Nov 24, 2020
@michael-milette michael-milette removed the hacktoberfest Contributions qualify for Digital Ocean Hacktoberfest label Nov 24, 2020
@argwallace
Copy link
Author

Hi Michael,

Just curious if there was any further development of this topic. Thanks and I appreciate the work you do.

Best regards,
Stephen

@michael-milette
Copy link
Owner

Hi Stephen,

There has not been any further development, however, I really appreciate the reminder as I was looking through the tickers just a few days ago deciding on what to work on next so this is good timing. I will not be able to work on this for a few weeks now but if you want to contribute, even if it is to point me to some other code that does something similar elsewhere, I would be happy to work on this with you.

Best regards,

Michael

@argwallace
Copy link
Author

argwallace commented Mar 1, 2021 via email

@michael-milette michael-milette self-assigned this Mar 16, 2021
@michael-milette
Copy link
Owner

Hi @argwallace

I am starting to work on this.

In the process, please note that I removed the Request a Course link from the from the course list. The functionality is still there but you will need to add a {courserequestmenu} tag. I know it has nothing to do with your request but I thought I would mention it in case you do use it. There is also a new {courserequestmenu0} tag in case you need a top level custom menu link.

I will give you more news when I have some for you.

Best regards,

Michael

@argwallace
Copy link
Author

argwallace commented Mar 16, 2021 via email

@michael-milette michael-milette changed the title Remove completed courses in {mycoursemenu} Remove completed courses in {mycoursesmenu} Apr 30, 2021
@michael-milette
Copy link
Owner

Hi @argwallace ,

I just added a new FilterCodes setting to allow you to hide completed courses in the {mycoursesmenu} tag.

image

This feature is currently only available in the version here on GitHub. If you would be so kind as to give it a try and let me know if this works for you, I would really appreciate it. If this meets your requirements, I will then include it in the upcoming release of FilterCodes on Moodle.org. It should be coming out in the next few weeks, around the same time as Moodle 3.11.

Best regards,

Michael Milette

@michael-milette michael-milette added the Ready for testing Feature has been implemented and we are waiting for participant to test. label Apr 30, 2021
@argwallace
Copy link
Author

argwallace commented Apr 30, 2021 via email

@argwallace
Copy link
Author

argwallace commented Apr 30, 2021 via email

@michael-milette michael-milette removed the Ready for testing Feature has been implemented and we are waiting for participant to test. label May 1, 2021
@Richardvi
Copy link

I just found this threat, but is there a delay on this? I have some courses with an end-date of 2019, yet they still show up in the 'mycoursesmenu'. I have checked the option to hide completed courses.

@michael-milette
Copy link
Owner

Hi @Richardvi ,

What version of FilterCodes are you using? Also, did you check the box in the FilterCodes settings?

image

@michael-milette
Copy link
Owner

michael-milette commented Aug 22, 2023

Hi @Richardvi - Looks like the code to address that is not included in in recent versions. Let me get back to you on that.

@michael-milette
Copy link
Owner

Hi @Richardvi

After reviewing this ticket and the code, this ticket relates to the removal of completed courses, not expired courses from the list.

So, if you are enrolled in a course that you did not complete before the end date of the course, the course will still show up in the menu.

Best regards,

Michael

@Richardvi
Copy link

Ah yes thanks! That makes sense. Sorry for misunderstanding this option :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New features, enhancements
Projects
None yet
Development

No branches or pull requests

3 participants