Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update For better RTL View #22

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Conversation

mortezasun
Copy link
Contributor

remove
android:layout_alignLeft="@android:id/title"
android:layout_alignStart="@android:id/title"

remove
   android:layout_alignLeft="@android:id/title"
            android:layout_alignStart="@android:id/title"
@michael-rapp
Copy link
Owner

michael-rapp commented Apr 27, 2017

I tested this and it seems to make no difference when using the RTL layout. In Android's official preference.xml file the android:layout_alignStart attribute is included as well (see e.g. http://grepcode.com/file/repository.grepcode.com/java/ext/com.google.android/android/5.1.1_r1/frameworks/base/core/res/res/layout/preference.xml/).

To me the preferences look well when using the RTL layout. Do you encounter any issues? If yes, a screenshot and more information about your device and Android version would be helpful.

@mortezasun
Copy link
Contributor Author

mortezasun commented Apr 27, 2017

in default mode : android 4.2.2 , Api 17 , 320 dpi, 1280*768 , genymotion
image 1

after remove
android:layout_alignLeft="@android:id/title"
android:layout_alignStart="@android:id/title"

image 2

Also in xlarge screen rtl view don't work correctly because assign margins in code
Google Nexus 9 android 6 Api 23
image 4

after change left margin to right margin :
image 3

@michael-rapp michael-rapp merged commit 5deeef9 into michael-rapp:master Apr 27, 2017
@michael-rapp
Copy link
Owner

Your changes are now part of version 4.2.11 of the library. I also fixed the hardcoded margins on tablets together with other minor RTL improvements. Thank you for your contribution.

@mortezasun
Copy link
Contributor Author

thank you for your awesome library

@mortezasun
Copy link
Contributor Author

I'm sorry, little bug in Orientation change , not keep state,
first launch: in android 6 api 23

image 6

and then rotate
image 5

@michael-rapp
Copy link
Owner

I will investigate on this, but it will take a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants