Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code change you can make to align with PHP 7.4 #8

Closed
wants to merge 3 commits into from
Closed

Code change you can make to align with PHP 7.4 #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
258520b
Code change you can make to align with PHP 7.4
dany-eudes Dec 19, 2021
db6ce5b
remove comments
michael-rubel Dec 20, 2021
28c17ef
apply php 7.4 tests
michael-rubel Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yml
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ jobs:
fail-fast: true
matrix:
os: [ubuntu-latest, windows-latest]
php: [8.0, 8.1]
php: [7.4, 8.0, 8.1]
laravel: [^8.69]
stability: [prefer-lowest, prefer-stable]
include:
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@
}
],
"require": {
"php": "^8.0|^8.1",
"php": "^7.4|^8.0|^8.1",
"ext-intl": "*",
"laravel/framework": "^8.69",
"spatie/laravel-package-tools": "^1.9"
Expand Down
2 changes: 1 addition & 1 deletion src/Helpers/helpers.php
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@
*
* @return mixed
*/
function format(string $formatter, mixed $items): mixed
function format(string $formatter, $items)
{
$formatter = class_exists($formatter) || interface_exists($formatter)
? app($formatter)
Expand Down