fix: Keep total order of migrations intact. (#1343)

The total order of migrations was not correctly recorded when a
repeatable migration was followed by 2 or more migrations that had
already been applied and a new one was added after those.

Fixes #1342.

neo4j-migrations-core/src/main/java/ac/simons/neo4j/migrations/core/Migrations.java

@@ -721,6 +721,7 @@ private void apply0(List<Migration> migrations) {
 					repeated = true;
 				} else {
 					LOGGER.log(Level.INFO, "Skipping already applied migration {0}", toString(migration));
+					previousVersion = migration.getVersion();
 					continue;
 				}
 			}

neo4j-migrations-core/src/test/java/ac/simons/neo4j/migrations/core/MigrationsIT.java

@@ -815,6 +815,37 @@ void shouldAllowCallInTX(String script) {
 		assertThat(appliedMigrations).isEqualTo(1);
 	}
 
+	@Test // 1342
+	void addingMigrationsAfterRepeatingOnesMustNotFail() {
+
+		var config = MigrationsConfig.builder().withLocationsToScan("classpath:repeatable/original", "classpath:repeatable/constant")
+			.build();
+
+		var migrations = new Migrations(config, driver);
+		migrations.clean(false);
+		migrations.info();
+		migrations.apply();
+
+		config = MigrationsConfig.builder().withLocationsToScan("classpath:repeatable/modified", "classpath:repeatable/constant", "classpath:repeatable/added")
+			.build();
+
+		migrations = new Migrations(config, driver);
+		migrations.apply();
+
+		// If chain is wrong, this would fail
+		assertThatNoException().isThrownBy(migrations::apply);
+
+		var records = driver.executableQuery("""
+			MATCH (:`__Neo4jMigration` {version:'BASELINE'}) (()-[:MIGRATED_TO]->()){4} (t:`__Neo4jMigration`)
+			RETURN t.version AS version
+			""").execute().records();
+		assertThat(records).hasSize(1).first().extracting(r -> r.get("version").asString()).isEqualTo("004");
+
+		var repetitionCnt = driver.executableQuery("MATCH (n:`__Neo4jMigration` {version: '001'})-[r:REPEATED]->(n) RETURN count(r) AS cnt")
+			.execute().records().get(0).get("cnt").asLong();
+		assertThat(repetitionCnt).isOne();
+	}
+
 	@Nested
 	class Repairing {
 

neo4j-migrations-test-resources/src/main/resources/repeatable/added/V004__na.cypher

@@ -0,0 +1 @@
+CREATE (n:V004);

neo4j-migrations-test-resources/src/main/resources/repeatable/constant/V002__na.cypher

@@ -0,0 +1 @@
+CREATE (n:V001);

neo4j-migrations-test-resources/src/main/resources/repeatable/constant/V003__na.cypher

@@ -0,0 +1 @@
+CREATE (n:V001);

neo4j-migrations-test-resources/src/main/resources/repeatable/modified/R001__na.cypher

@@ -0,0 +1 @@
+CREATE (n:R1Modified);

neo4j-migrations-test-resources/src/main/resources/repeatable/original/R001__na.cypher

@@ -0,0 +1 @@
+CREATE (n:R1);