Fix crashes

michaelWuensch · Sep 20, 2023 · 00b98e7 · 00b98e7
1 parent c181699
commit 00b98e7
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 16 deletions.
diff --git a/app/src/main/java/app/michaelwuensch/bitbanana/lnurl/withdraw/LnUrlWithdrawBSDFragment.java b/app/src/main/java/app/michaelwuensch/bitbanana/lnurl/withdraw/LnUrlWithdrawBSDFragment.java
@@ -31,10 +31,6 @@
 import java.net.MalformedURLException;
 import java.net.URL;
 
-import okhttp3.Call;
-import okhttp3.Callback;
-import okhttp3.Request;
-import okhttp3.Response;
 import app.michaelwuensch.bitbanana.R;
 import app.michaelwuensch.bitbanana.connection.HttpClient;
 import app.michaelwuensch.bitbanana.connection.lndConnection.LndConnection;
@@ -43,10 +39,14 @@
 import app.michaelwuensch.bitbanana.customView.BSDScrollableMainView;
 import app.michaelwuensch.bitbanana.customView.NumpadView;
 import app.michaelwuensch.bitbanana.fragments.BaseBSDFragment;
+import app.michaelwuensch.bitbanana.util.BBLog;
 import app.michaelwuensch.bitbanana.util.MonetaryUtil;
 import app.michaelwuensch.bitbanana.util.PrefsUtil;
 import app.michaelwuensch.bitbanana.util.Wallet;
-import app.michaelwuensch.bitbanana.util.BBLog;
+import okhttp3.Call;
+import okhttp3.Callback;
+import okhttp3.Request;
+import okhttp3.Response;
 
 
 public class LnUrlWithdrawBSDFragment extends BaseBSDFragment {
@@ -379,11 +379,16 @@ public void onClick(View v) {
     private void validateSecondResponse(@NonNull String withdrawResponse) {
         LnUrlWithdrawResponse lnUrlWithdrawResponse = new Gson().fromJson(withdrawResponse, LnUrlWithdrawResponse.class);
 
-        if (lnUrlWithdrawResponse.getStatus().equals("OK")) {
-            switchToSuccessScreen();
+        if (lnUrlWithdrawResponse.getStatus() != null) {
+            if (lnUrlWithdrawResponse.getStatus().equals("OK")) {
+                switchToSuccessScreen();
+            } else {
+                BBLog.d(LOG_TAG, "LNURL: Failed to withdraw. " + lnUrlWithdrawResponse.getReason());
+                switchToFailedScreen(lnUrlWithdrawResponse.getReason());
+            }
         } else {
-            BBLog.d(LOG_TAG, "LNURL: Failed to withdraw. " + lnUrlWithdrawResponse.getReason());
-            switchToFailedScreen(lnUrlWithdrawResponse.getReason());
+            BBLog.d(LOG_TAG, "LNURL: Failed to withdraw. " + withdrawResponse);
+            switchToFailedScreen(withdrawResponse);
         }
     }
 

diff --git a/app/src/main/java/app/michaelwuensch/bitbanana/util/Wallet.java b/app/src/main/java/app/michaelwuensch/bitbanana/util/Wallet.java
@@ -19,7 +19,6 @@
 import com.github.lightningnetwork.lnd.lnrpc.GetInfoRequest;
 import com.github.lightningnetwork.lnd.lnrpc.GetStateRequest;
 import com.github.lightningnetwork.lnd.lnrpc.GetTransactionsRequest;
-import com.github.lightningnetwork.lnd.lnrpc.Initiator;
 import com.github.lightningnetwork.lnd.lnrpc.Invoice;
 import com.github.lightningnetwork.lnd.lnrpc.InvoiceSubscription;
 import com.github.lightningnetwork.lnd.lnrpc.LightningAddress;
@@ -923,15 +922,19 @@ public void fetchLockedUTXOs() {
      * @return remote pub key
      */
     public String getRemotePubKeyFromChannelId(long chanId) {
-        for (Channel channel : mOpenChannelsList) {
-            if (channel.getChanId() == chanId) {
-                return channel.getRemotePubkey();
+        if (mOpenChannelsList != null) {
+            for (Channel channel : mOpenChannelsList) {
+                if (channel.getChanId() == chanId) {
+                    return channel.getRemotePubkey();
+                }
             }
         }
         // ToDo: Add pending channels
-        for (ChannelCloseSummary channelCloseSummary : mClosedChannelsList) {
-            if (channelCloseSummary.getChanId() == chanId)
-                return channelCloseSummary.getRemotePubkey();
+        if (mClosedChannelsList != null) {
+            for (ChannelCloseSummary channelCloseSummary : mClosedChannelsList) {
+                if (channelCloseSummary.getChanId() == chanId)
+                    return channelCloseSummary.getRemotePubkey();
+            }
         }
 
         return null;