Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly detect disconnections from the bridge #5

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Properly detect disconnections from the bridge #5

merged 2 commits into from
Apr 11, 2023

Conversation

michaelarnauts
Copy link
Owner

@michaelarnauts michaelarnauts commented Apr 11, 2023 •
edited
Loading

  • Raise an AioComfoConnectTimeout when the a reply wasn't received within the timout.

This allows us to properly detect a disconnection.

This can be tested by running python ./aiocomfoconnect --debug show-sensors --host zehnder-bridge.lan and then blocking access to the bridge with iptables.

Block access

$ iptables -A INPUT -s 192.168.1.213 -j DROP

Unlock access

$ iptables -D INPUT -s 192.168.1.213 -j DROP

@michaelarnauts michaelarnauts changed the title Reconnect to the bridge when the connection got disconnected Properly detect disconnections from the bridge Apr 11, 2023
@michaelarnauts michaelarnauts mentioned this pull request Apr 11, 2023
Closed
@michaelarnauts michaelarnauts merged commit 383cb94 into master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@michaelarnauts