Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TerminalWithCode display #125

Closed
michaelb opened this issue Dec 12, 2021 · 3 comments
Closed

TerminalWithCode display #125

michaelb opened this issue Dec 12, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@michaelb
Copy link
Owner

It could be nice to have the Terminal display also display the sniprun'd code along with the result.

Future discussion about the feature included in #123 can happen here, if the PR is merged into dev
@michaelb michaelb added the enhancement New feature or request label Dec 12, 2021
@michaelb
Copy link
Owner Author

@control13 I merged your PR with some improvement into master, soon to be v1.1.0

(including this Terminal/TerminalWithCode duplicated output if both key present, as well as un-indentation of the sniprun'd code bloc)

If you think this is good enough, feel free to close this issue (or let me know why otherwise)

@control13
Copy link

control13 commented Dec 14, 2021 •
edited

It's nice and you were quite fast, too. We got it.
(And I don't have permission to close the issue. But it can.)

@michaelb
Copy link
Owner Author

Oh, maybe it's because I was the one who created it... Nevermind then

Have a nice day and thanks for the contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@control13 @michaelb