New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal with code history #123
Conversation
fix REPL interpreters not closing + isolate different repl from different neovim instances
fix escaping sequences in output
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 59.34% 59.42% +0.08%
==========================================
Files 35 35
Lines 5667 5696 +29
==========================================
+ Hits 3363 3385 +22
- Misses 2304 2311 +7
Continue to review full report at Codecov.
|
Wow, thank you for the nice addition! There's still a few things that are a bit off (mainly typos & format, but also sniprun shouldn't allow both Terminal and TerminalWithCode to be turned on at the same time), so I'd like to either:
Which one do you prefer ? Also, don't mind about the version numbers in the cargo.toml / cargo lock update status, especially if you're pushing on the dev branch. I update those for each release, and you might just be off-sync |
fix #124 |
Oh nice. Yeah, I prefer the first option (redirect it to dev).
Obviously! Totally forgot about that. Thank you very much for your help. |
Hello,
I found it helpful, when the executed code line or bloc is also printed to the terminal. So I wrote a
TerminalWithCode
display for that. It works nicely with the fix #122 from @michaelb.The output then looks like this:
Thank you for this nice project.
I also added a minimum to the documentation. But I have concerns that I messed up the version number the cargo.lock. It shows version 1.0.6. Hmm?