Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vars may produce duplicates #21

Open
michaelballantyne opened this issue Dec 16, 2022 · 0 comments
Open

vars may produce duplicates #21

michaelballantyne opened this issue Dec 16, 2022 · 0 comments

Comments

@michaelballantyne
Copy link
Owner

faster-minikanren/mk.scm

Lines 565 to 571 in dc5390a

(define (vars term)
(let rec ((term term) (acc '()))
(cond
((var? term) (cons term acc))
((pair? term)
(rec (cdr term) (rec (car term) acc)))
(else (remove-duplicates acc)))))

When term is a pair such as (,x . ,x), the result would include two instances of the var. Not sure if this would lead to bad reification later or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant