Fix bug related to memory leakage when calling vTaskEndScheduler #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function must be invoked from main thread and it destroys mutex which guards the list of threads to be joined.
The threads which are running when the scheduler is being stopped are since now canceled and joined. The thread which called vTaskEndScheduler must be treated in a special way because it mustn't cancel itself. pthread_t of this thread is saved and then by calling vPortJoinSchedulerEndCaller from main thread cancels the thread and joins it.
On pthread_exit pthread_t is saved on a list and then on cleaning up the application (by calling vPortJoinSchedulerEndCaller) those threads are joined. This commit also implements handling the list of pthreads' IDs.
|
Some changes manually merged into master. Did not include code that joined threads, pthread detach handles this better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests addresses the issue #14. A new function has been added which cleans up resources. To gracefully stop the scheduler a function
vTaskEndSchedulermust be called within task code and thenvPortCleanupmust be called after the call tovTaskStartSchedulerfrom the main thread.