Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks are broken for comments that aren't on the 1st page #20

Open
michaelboyles opened this issue Jul 18, 2021 · 0 comments
Open
Labels
bug Something isn't working

Comments

@michaelboyles
Copy link
Owner

Permalinks used to jump directly to a post (e.g. if 'Share' is clicked) when the user loaded the page. It still works but, since pagination was added (#17), only if the item is visible after the first GET. If the comment is a reply or isn't on the first page it will do nothing.

One way to solve this would be the change the initial GET request to add an optional query parameter e.g. ?permalink=some-comment-id. Then the back-end could make sure that item was included.

Also considering removing permalinks for now too.

@michaelboyles michaelboyles added the bug Something isn't working label Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant