fix for issue #9 => prepare_job_execution() takes 2 positional arguments but 3 were given #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tional arguments but 3 were given "prepare_job_execution" takes 2 input param including self, but the calling statement passes 3 with additional "heartbeat_ttl" which is not used but the method, i have removed the extra input param and issue seems to be solved for me.
|
Thank you! I see this interface was changed in rq here: rq/rq#1372 Could you update setup.py to version 0.4.0 and make the minimum rq version 1.8.1? I'm not sure that this will behave as expected with older rq versions. |
updated package version to 0.4.0 and minimum rq version to 1.8.1
|
I have updated setup.py to version 0.4.0 and made the minimum rq version 1.8.1 |
michaelbrooks
approved these changes
Jul 8, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"prepare_job_execution" takes 2 input param including self, but the calling statement passes 3 with additional "heartbeat_ttl" which is not used by the method, I have removed the extra input param and issue seems to be solved for me.