Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Language parameter #2

Closed
Deurnieur opened this issue Jun 27, 2019 · 5 comments
Closed

Add Language parameter #2

Deurnieur opened this issue Jun 27, 2019 · 5 comments

Comments

@Deurnieur
Copy link

Hi,
Is it possible to add a language parameter ? (French or English)

English:
XML_URL_BASE = 'http://dd.weatheroffice.ec.gc.ca/citypage_weather/xml/{}_e.xml'

French:
XML_URL_BASE = 'http://dd.weatheroffice.ec.gc.ca/citypage_weather/xml/{}_f.xml'

Thanks
@michaeldavie
Copy link
Owner

Sure, I can take a look at this. Are you interested in exposing the French for Home Assistant, or just in general?

@Deurnieur
Copy link
Author

French for Home Assistant

Thanks

@michaeldavie
Copy link
Owner

I added this in 0.0.12, and I'll work on adding it to Home Assistant as well. If you could test it, that would be great.

@Deurnieur
Copy link
Author

Great! I will tes it.

Thanks

@michaeldavie
Copy link
Owner

I've made a PR with this feature: https://github.com/home-assistant/home-assistant/pull/24884/files

@michaeldavie michaeldavie mentioned this issue Jul 2, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaeldavie @Deurnieur