Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slides team Decks #36

Closed
MichaelDeBoey opened this issue Oct 23, 2019 · 2 comments · Fixed by #37
Closed

Fix Slides team Decks #36

MichaelDeBoey opened this issue Oct 23, 2019 · 2 comments · Fixed by #37
Assignees
Labels
🐛 Bug Something isn't working released ⚙️ Slides Issue or pull request regarding Slides 👷 Someone Working on It

Comments

@MichaelDeBoey
Copy link
Owner

MichaelDeBoey commented Oct 23, 2019

@MichaelDeBoey (https://twitter.com/MichaelDeBoey93/status/1186980179555639296)

I just found out acme.slides.com is a valid team Deck link too.
Is this an exception (and is every other team Deck link on team.slides.com) or can each team have his own custom subdomain? 🤔

@hakimel (https://twitter.com/hakimel/status/1187010242514706432)

Each team has their own custom subdomain. Sorry that wasn’t clear in my examples!

@MichaelDeBoey MichaelDeBoey added 🐛 Bug Something isn't working 👷 Someone Working on It ⚙️ Slides Issue or pull request regarding Slides labels Oct 23, 2019
@anuraghazra
Copy link
Contributor

this check is passing in shouldTransform

  return (
    !!host.match(/^((^[a-zA-Z0-9]+\.)?slides\.com$)/gi) &&
    getTrimmedPathName(pathname).split('/').length === 2
  );

(needs more testing)

@MichaelDeBoey
Copy link
Owner Author

🎉 This issue has been resolved in version 1.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working released ⚙️ Slides Issue or pull request regarding Slides 👷 Someone Working on It
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants