Make the commits prefix configurable

[reicolina]

• This is for issues Remove the space before the output #15 and Add an argument to make the prompt more minimalistic (shorter) #17
• To keep the implementation as simple as possible the opening and closing parenthesis "(..)" will still be shown. The new GIT_RADAR_COMMITS_PREFIX will only affect/overwrite the git: part of the prefix.
• Also added documentation in the README file.

Please let me know if you have any feedback, suggestions or questions.

Thanks!

[mengelbrecht]

Making the parenthesis also configurable would greatly simplify the integration of git-radar into custom prompt themes.

[reicolina]

It is almost like the parenthesis would deserve a separate ENV variable. More than a prefix, it would be considered a wrapper. We could just make that variable to accept two chars; the opening and the closing char "()" Or we can have one variable for the opening "(" char or another for the closing one ")".

Alternatively we could also accept something like this "(%c)", where %c is where the commit prompt text will be placed within the wrapper. We could even make it part of the prefix variable and configure it with something like "git:(%c)" This option will require users to remember to use that %c within the ENV variable tho.

Thoughts?

[mengelbrecht]

I am voting for making it part of the prefix variable and configurable like you proposed, e.g. git:(%c).
This approach is very flexible and also simple to use.

[reicolina]

Thanks for your feedback @mgee.
@michaeldfallen: any thoughts before I go ahead and modify this PR to implement what's discussed above?

[michaeldfallen]

The %c idea is interesting. This whole time I've been treating it as something you build but what if it was declarative? Something like:

%r = remote commits
%l = local commits
%b = branch name or reference
%c = file changes

then you can build anything:

git:(%r %b %l) %c, %r [%b %l] %c, branch: %b %l, etc.

Sounds very flexible way of doing it. My one concern would be that %[character] is obtuse. Maybe prefer %{[name]} i.e. delimiting with { } to show the difference between the code and the next character to render?

It would need to change the way prompt.bash and prompt.zsh works quite fundamentally, grepping through the format string to find all the %{[name]}'s and executing the correct function sequence, including printing any string characters that aren't %{[name]}s. Really nice idea though, I like it.

[reicolina]

%{[name]} is the format i was looking for when i wrote %[character] 😸
I'll take a swing at this within the next day or two.
Thanks!

[michaeldfallen]

@reinaldo13 I had a few free days this week and decided to implement that proposal we were talking about. #65, what do you think?

[reicolina]

It looks good @michaeldfallen! Thanks for taking the time to work on this! 🤘 and my apologies for not being able to take care of it earlier.

[michaeldfallen]

Don't worry, took me long enough to merge it anyway. Going to close this now.