Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with ramsey/uuid:^4.1 #94

Closed
wants to merge 1 commit into from
Closed

Fix compatibility with ramsey/uuid:^4.1 #94

wants to merge 1 commit into from

Conversation

caiquecastro
Copy link
Contributor

No description provided.

@caiquecastro
Copy link
Contributor Author

Needs to change on dyrynda/laravel-efficient-uuid package:

image

@caiquecastro
Copy link
Contributor Author

Probably fix #93

@michaeldyrynda
Copy link
Owner

I don't think this will preserve functionality, though, as you're just resolving implicitly from string or bytes, rather than a specific version.

@michaeldyrynda
Copy link
Owner

That said, I don't think you can really use UUID versions 2, 3, or 5 anyway, as they require additional parameters be passed anyway.

michaeldyrynda added a commit that referenced this pull request Aug 2, 2020
@michaeldyrynda
Copy link
Owner

Fixed in b273499

@ziming
Copy link

ziming commented Aug 2, 2020

@michaeldyrynda

If 'ordered' is now pipe through uuid 6 (said in the release notes), will it have any conflicts or issues with my previous uuids that are already generated with Str::orderedUuid() ? Like will my uuid column still be correctly indexed in an ordered manner? with a mix of uuid 6 and Str::orderedUuid()?

https://github.com/laravel/framework/blob/7.x/src/Illuminate/Support/Str.php#L693

Hopefully you know the answer, thank you.

@michaeldyrynda
Copy link
Owner

It may be possible, given that the ordered UUID does not appear to actually be a proper time-ordered UUID.

It may be worth considering updating the UUID to use the new format which forms a truer representation of an ordered UUID, albeit from a draft specification.

@ziming
Copy link

ziming commented Aug 2, 2020

Noted the potential breaking changes, shall restrict to 6.1.1 for this package for the time being then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants