Change the scopeName of javascriptreact to "source.js" #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of 74258ca the scopeName `source.js.jsx` doesn't exist anymore so to make michaelgmcd#30 work we need to map the `javascriptreact` grammar to `source.js`. Also, added the extension `.js` to the language identifier so it can work with js files that have `Javascript React` as the language id. too.
|
Good catch! |
michaelgmcd
approved these changes
Jun 22, 2018
|
Thanks for the prompt reaction! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of 74258ca the scopeName
source.js.jsxdoesn't exist anymore so to make #30 work we need to map thejavascriptreactgrammar tosource.js.Also, added the extension
.jsto the language identifier so it can work with js files that haveJavascript Reactas the language id. too.