Update requests==2.8 in setup.py, too #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, thanks! Forgot to catch that. Mind updating Also, if you could do me one more solid, update them all to 2.8.1 rather than 2.8.0? :D |
|
@michaelhelmick happy to do so. |
|
@michaelhelmick made the setup.py read the requirements.txt instead. hope that is less error prone. before you release the new version, I have problems running it here on python3.5 (will open a new ticket) – mind helping me figuring that out before? |
michaelhelmick
added a commit
that referenced
this pull request
Nov 11, 2015
Update requests==2.8 in setup.py, too
|
Sure, just post the stacktrace or any errors you're getting. Might not be able to help til later today. But I'll have a whack at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changelog for the last release states, that request is now pinned at version 2.8, yet when installing the latest version of lassie, it requires (and install) version 2.6 – the setup.py hasn't been updated to reflect that change and breaks the installation. This PR corrects that.