Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: 2.0.0 #23

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

WIP: 2.0.0 #23

wants to merge 27 commits into from

Conversation

michaelhelmick
Copy link
Owner

This isn't finished yet.

Also, nothing really broke in this version; I wanted to start a clean versioning. When I first forked this repo and started maintaining it, the package versioning was based on the actual MailChimp API; and not changes in the code itself.

TODO:

  • HISTORY.rst

brad and others added 27 commits August 27, 2012 22:29
…sts from mailsnake/tests (all tests now pass)
…h nosetests from mailsnake/tests (all tests now pass)"

This reverts commit ebb3109.
…sts from mailsnake/tests (all tests now pass)
Added test for calling .lists with incorrect apikey
- Update LICENSE
- Integrate Travis
- PEP8 things
- General code clean up
[ci skip]
[ci skip]
@bsdlp
Copy link

bsdlp commented Apr 7, 2014

@michaelhelmick is there anything else that needs to be done for this PR to be merged?

@michaelhelmick
Copy link
Owner Author

@fly I'm unsure. It's been a while since I've had time to take a look at this. I'm a little upset that I let it get away from me, but I just haven't had spare time to try and get this release together. :/

@brad
Copy link
Collaborator

brad commented Apr 7, 2014

@michaelhelmick Is there anything I can do to help?

@michaelhelmick
Copy link
Owner Author

@brad I think we could use https://github.com/dropbox/responses to mock our responses in tests. Rather than how we initially did these. I'm not sure if that's pressing now. I'd say just test a few API calls. I'm not sure what else we wanted to get into 2.0.0 -- I know file structure was one of them

@brad
Copy link
Collaborator

brad commented Apr 7, 2014

@michaelhelmick Yeah, mocked requests sound good, then we won't be spamming the mailchimp servers every time we run tests 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants