New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: 2.0.0 #23
base: master
Are you sure you want to change the base?
WIP: 2.0.0 #23
Conversation
…sts from mailsnake/tests (all tests now pass)
…h nosetests from mailsnake/tests (all tests now pass)" This reverts commit ebb3109.
…sts from mailsnake/tests (all tests now pass)
…incorrect apikeys
Added test for calling .lists with incorrect apikey
- Update LICENSE - Integrate Travis - PEP8 things - General code clean up
[ci skip]
[ci skip]
@michaelhelmick is there anything else that needs to be done for this PR to be merged? |
@fly I'm unsure. It's been a while since I've had time to take a look at this. I'm a little upset that I let it get away from me, but I just haven't had spare time to try and get this release together. :/ |
@michaelhelmick Is there anything I can do to help? |
@brad I think we could use https://github.com/dropbox/responses to mock our responses in tests. Rather than how we initially did these. I'm not sure if that's pressing now. I'd say just test a few API calls. I'm not sure what else we wanted to get into 2.0.0 -- I know file structure was one of them |
@michaelhelmick Yeah, mocked requests sound good, then we won't be spamming the mailchimp servers every time we run tests 👍 |
This isn't finished yet.
Also, nothing really broke in this version; I wanted to start a clean versioning. When I first forked this repo and started maintaining it, the package versioning was based on the actual MailChimp API; and not changes in the code itself.
TODO: