Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request() fails if Tumblr returns https:// URL #39

Closed
patrick-brian-mooney opened this issue Feb 21, 2016 · 2 comments
Closed

request() fails if Tumblr returns https:// URL #39

patrick-brian-mooney opened this issue Feb 21, 2016 · 2 comments

Comments

@patrick-brian-mooney
Copy link

I'm playing with a new Tumblr blog and using Tumblpy; it took me a bit to find out why it was failing. On my new blog,

the_client.post('user/info')['user']['blogs'][0]['url']

returns a secure HTTP URL; lines 112 and 113 of api.py fail because they're explicitly matching for 'http://'.

Currently, I'm working around it by replacing 'https://' with 'http://' in a wrapper script, which seems to work fine.
michaelhelmick pushed a commit that referenced this issue Mar 21, 2016
Fixes #39, add support for secure API urls
1198cf3
@michaelhelmick
Copy link
Owner

Sorry for the late response. Think you can test out this branch and make sure it works for your case?

#40

I'll merge and push a release if it all checks out!

@michaelhelmick
Copy link
Owner

/ping @patrick-brian-mooney

bomb-on pushed a commit to bomb-on/python-tumblpy that referenced this issue Dec 4, 2016
@mklappir
Update api.py
e24fa4f 
Fixes michaelhelmick#39 and michaelhelmick#45 - URL was not parsed properly if the blog is served over HTTPS.
@bomb-on bomb-on mentioned this issue Dec 4, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelhelmick @patrick-brian-mooney