Move to src layout and fix build process #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original test didn't show it because Python was smartly loading the files from the current directory. This change makes the virtualenv in a temporary directory, installs the wheel, and runs the smoke test from that context. This means it cannot pick up on the local files anymore. This should lead to a failed test. If so, I will adjust the project file to fix the issue.
The 2.0.0 release was botched due to a packaging error where the package directory was misnamed as `pyIsEmail` instead of the expected `pyisemail`. This was due to Python automatically adding the current directory to the `PYTHONPATH` when invoked and my time of being away from Python and forgetting that. This change reorganizes the repository around the [src layout][1] which prevents the issue since an `import pyisemail` will no longer load from the current path. It also changes the test setup to install the package in the environment instead of using an editable install. This way we're actually using the built wheel as the source of the packages, which verifies that the wheel works as expected. [1]: https://blog.ionelmc.ro/2014/05/25/python-packaging/
michaelherold
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2.0.0 release was botched due to a packaging error where the package directory was misnamed as
pyIsEmailinstead of the expectedpyisemail. This was due to Python automatically adding the current directory to thePYTHONPATHwhen invoked and my time of being away from Python and forgetting that.This change reorganizes the repository around the src layout which prevents the issue since an
import pyisemailwill no longer load from the current path. It also changes the test setup to install the package in the environment instead of using an editable install. This way we're actually using the built wheel as the source of the packages, which verifies that the wheel works as expected.Fixes #30