Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_wrapped_native_account() implemented #74

Merged

Conversation

kuznetsov-m
Copy link
Contributor

No description provided.

@michaelhly
Copy link
Owner

@kuznetsov-m thank you for contributing! But to merge in your PRs, please run make lint and make format locally so that your PRs will pass the CI tests. Thank you!

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #74 (2037897) into master (36a9eaf) will decrease coverage by 1.08%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   89.60%   88.52%   -1.09%     
==========================================
  Files          25       25              
  Lines        1414     1429      +15     
==========================================
- Hits         1267     1265       -2     
- Misses        147      164      +17     

@kuznetsov-m
Copy link
Contributor Author

kuznetsov-m commented Jun 11, 2021

@michaelhly Thanks for the advice! I didn't really execute these commands.
During the execution of the make lint (master branch) command and received the following error:

...
pipenv run mypy --namespace-packages --explicit-package-bases spl
Loading .env environment variables...
usage: mypy [-h] [-v] [-V] [more options; see below]
            [-m MODULE] [-p PACKAGE] [-c PROGRAM_TEXT] [files ...]
mypy: error: unrecognized arguments: --explicit-package-bases
make: *** [lint] Error 2

Could you help me with this error?

@michaelhly
Copy link
Owner

@michaelhly Thanks for the advice! I didn't really execute these commands.
During the execution of the make lint (master branch) command and received the following error:

...
pipenv run mypy --namespace-packages --explicit-package-bases spl
Loading .env environment variables...
usage: mypy [-h] [-v] [-V] [more options; see below]
            [-m MODULE] [-p PACKAGE] [-c PROGRAM_TEXT] [files ...]
mypy: error: unrecognized arguments: --explicit-package-bases
make: *** [lint] Error 2

Could you help me with this error?

What version of mypy do you have installed?

@kuznetsov-m
Copy link
Contributor Author

kuznetsov-m commented Jun 12, 2021

@michaelhly Thanks for the advice! I didn't really execute these commands.
During the execution of the make lint (master branch) command and received the following error:

...
pipenv run mypy --namespace-packages --explicit-package-bases spl
Loading .env environment variables...
usage: mypy [-h] [-v] [-V] [more options; see below]
            [-m MODULE] [-p PACKAGE] [-c PROGRAM_TEXT] [files ...]
mypy: error: unrecognized arguments: --explicit-package-bases
make: *** [lint] Error 2

Could you help me with this error?

What version of mypy do you have installed?

Environment installed from Pipfile.lock
pipenv install --dev

"version": "==0.782"

mypy                          0.782      
mypy-extensions               0.4.3

I read in the documentation about --namespace-packages and --explicit-package-bases flags. Therefore, these arguments must be known to mypy. I seem to be doing something wrong.

@michaelhly
Copy link
Owner

michaelhly commented Jun 15, 2021

@michaelhly Thanks for the advice! I didn't really execute these commands.
During the execution of the make lint (master branch) command and received the following error:

...
pipenv run mypy --namespace-packages --explicit-package-bases spl
Loading .env environment variables...
usage: mypy [-h] [-v] [-V] [more options; see below]
            [-m MODULE] [-p PACKAGE] [-c PROGRAM_TEXT] [files ...]
mypy: error: unrecognized arguments: --explicit-package-bases
make: *** [lint] Error 2

Could you help me with this error?

What version of mypy do you have installed?

Environment installed from Pipfile.lock
pipenv install --dev

"version": "==0.782"

mypy                          0.782      
mypy-extensions               0.4.3

I read in the documentation about --namespace-packages and --explicit-package-bases flags. Therefore, these arguments must be known to mypy. I seem to be doing something wrong.

Can you try pulling in the latest master, run rm -rf Pipfile.lock and then run pipenv install --dev again?

@kuznetsov-m
Copy link
Contributor Author

@michaelhly Thanks for the advice! I didn't really execute these commands.
During the execution of the make lint (master branch) command and received the following error:

...
pipenv run mypy --namespace-packages --explicit-package-bases spl
Loading .env environment variables...
usage: mypy [-h] [-v] [-V] [more options; see below]
            [-m MODULE] [-p PACKAGE] [-c PROGRAM_TEXT] [files ...]
mypy: error: unrecognized arguments: --explicit-package-bases
make: *** [lint] Error 2

Could you help me with this error?

What version of mypy do you have installed?

Environment installed from Pipfile.lock
pipenv install --dev

"version": "==0.782"

mypy                          0.782      
mypy-extensions               0.4.3

I read in the documentation about --namespace-packages and --explicit-package-bases flags. Therefore, these arguments must be known to mypy. I seem to be doing something wrong.

Can you try pulling in the latest master, run rm -rf Pipfile.lock and then run pipenv install --dev again?

Now it works great! Thank you!
make lint and make format do not require any modifications to this PR. Is there anything else to improve this PR?

@michaelhly
Copy link
Owner

michaelhly commented Jun 16, 2021

@kuznetsov-m are you sure? CI says you need to run make format.
https://github.com/michaelhly/solana-py/pull/74/checks?check_run_id=2835415365

@kuznetsov-m
Copy link
Contributor Author

@michaelhly really sorry, I missed changes.

@kuznetsov-m
Copy link
Contributor Author

@michaelhly It seems I managed to pass all the checks. Are there any more recommendations for edits?

spl/token/client.py Outdated Show resolved Hide resolved
@michaelhly
Copy link
Owner

Thank you for contributing!

@michaelhly michaelhly merged commit e4cc525 into michaelhly:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants