Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When section has multiple preview targets, plugin settings overlay target selector #4

Closed
jwrudzin opened this issue Sep 23, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@jwrudzin
Copy link

Description

When a section has multiple preview targets, the breakpoint plugin settings overlay the preview target selector and the selector can't be accessed.

Screen Shot 2020-09-22 at 9 09 33 PM

Screen Shot 2020-09-22 at 9 08 43 PM

To Reproduce

Steps to reproduce the behavior:

  1. Install breakpoint plugin.
  2. Set up multiple preview targets for a section.
  3. Open live preview for that section and trigger breakpoint plugin.

Expected behavior

Plugin styles should adjust to move breakpoint settings out of the way of the preview target selector.

Additional context

  • Plugin version: 2.2.1
  • Craft version: 3.4.24
  • Browser and version: Chrome 85.0.4183.121
@michaelhue
Copy link
Owner

Hey, thanks for the report!
I believe this is a duplicate of issue #2.

This is a problem with Craft 3.4, check this issue over on the Craft repo. It has been fixed in 3.5.

Would it be possible to update your project to the latest Craft version?

@jwrudzin
Copy link
Author

Hi @michaelhue!

Unfortunately, I'm still seeing this issue in Craft 3.5.10.1. It appears that Craft issue (#5547) refers to the live preview content being hidden underneath the header, but doesn't reference the issue with the content inside the header.

@michaelhue
Copy link
Owner

Thanks for checking. I'll look into it!

@jwrudzin
Copy link
Author

Hi @michaelhue just checking to see if you've had a chance to look into this yet? Thanks!

@michaelhue
Copy link
Owner

Hey @jwrudzin, the issue should be fixed now. Please update to version 2.2.2.

Thanks for your patience!

@michaelhue michaelhue added the bug Something isn't working label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants