Fixes Node not starting (pixijs#8497)

michaeljherrmann · Jul 15, 2022 · 011feab · 011feab
1 parent ffa04c3
commit 011feab
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/bundles/pixi.js-node/README.md b/bundles/pixi.js-node/README.md
@@ -36,6 +36,7 @@ To build from source you will need to make sure you have the following dependenc
 ```js
 import { Application, Sprite, Assets } from '@pixi/node';
 import path from 'path';
+import { writeFileSync } from 'fs';
 
 // This package requires the new asset loader to be used.
 // Initialize the new assets loader
@@ -68,9 +69,9 @@ app.ticker.add(() => {
 });
 
 // extract and save the stage
-app.renderer.render(stage);
+app.renderer.render(app.stage);
 const base64Image = app.renderer.plugins.extract
-    .canvas(stage)
+    .canvas(app.stage)
     .toDataURL('image/png');
 
 const base64Data = base64Image.replace(/^data:image\/png;base64,/, '');

diff --git a/packages/core/src/extensions.ts b/packages/core/src/extensions.ts
@@ -226,7 +226,10 @@ const extensions = {
             {
                 list.push(extension.ref);
                 // TODO: remove me later, only added for @pixi/loaders
-                extension.ref.add?.();
+                if (type === ExtensionType.Loader)
+                {
+                    extension.ref.add?.();
+                }
             },
             (extension) =>
             {