Skip to content

Commit

Permalink
Hotfix: Make sure core isn't bundled in ticker, canvas-sprite, canvas…
Browse files Browse the repository at this point in the history
…-mesh (pixijs#8527)
  • Loading branch information
bigtimebuddy committed Jul 24, 2022
1 parent 63b9f0c commit 27365ba
Show file tree
Hide file tree
Showing 16 changed files with 109 additions and 9 deletions.
1 change: 1 addition & 0 deletions bundles/pixi.js-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"@pixi/constants": "6.5.0",
"@pixi/core": "6.5.0",
"@pixi/display": "6.5.0",
"@pixi/extensions": "6.5.0",
"@pixi/extract": "6.5.0",
"@pixi/filter-alpha": "6.5.0",
"@pixi/filter-blur": "6.5.0",
Expand Down
1 change: 1 addition & 0 deletions bundles/pixi.js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"@pixi/constants": "6.5.0",
"@pixi/core": "6.5.0",
"@pixi/display": "6.5.0",
"@pixi/extensions": "6.5.0",
"@pixi/extract": "6.5.0",
"@pixi/filter-alpha": "6.5.0",
"@pixi/filter-blur": "6.5.0",
Expand Down
20 changes: 20 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/canvas-mesh/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"*.d.ts"
],
"peerDependencies": {
"@pixi/core": "6.5.0",
"@pixi/canvas-display": "6.5.0",
"@pixi/canvas-renderer": "6.5.0",
"@pixi/constants": "6.5.0",
Expand Down
1 change: 1 addition & 0 deletions packages/canvas-sprite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"@pixi/canvas-display": "6.5.0",
"@pixi/canvas-renderer": "6.5.0",
"@pixi/constants": "6.5.0",
"@pixi/core": "6.5.0",
"@pixi/math": "6.5.0",
"@pixi/sprite": "6.5.0",
"@pixi/utils": "6.5.0"
Expand Down
1 change: 1 addition & 0 deletions packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
},
"peerDependencies": {
"@pixi/constants": "6.5.0",
"@pixi/extensions": "6.5.0",
"@pixi/math": "6.5.0",
"@pixi/runner": "6.5.0",
"@pixi/settings": "6.5.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/Renderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import type { IRendererOptions, IRendererPlugins, IRendererRenderOptions,
import type { ISystemConstructor } from './ISystem';
import type { IRenderingContext } from './IRenderingContext';
import type { IRenderableObject } from './IRenderableObject';
import { extensions, ExtensionType } from './extensions';
import { extensions, ExtensionType } from '@pixi/extensions';

export interface IRendererPluginConstructor
{
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/batch/BatchPluginFactory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import defaultVertex from './texture.vert';
import defaultFragment from './texture.frag';

import type { Renderer } from '../Renderer';
import type { ExtensionMetadata } from '../extensions';
import { ExtensionType } from '../extensions';
import type { ExtensionMetadata } from '@pixi/extensions';
import { ExtensionType } from '@pixi/extensions';

export interface IBatchFactoryOptions
{
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import './settings';
*/
export const VERSION = '$_VERSION';

export * from './extensions';
export * from '@pixi/extensions';
export * from './textures/resources';
export * from './systems';
export * from './IRenderingContext';
Expand Down
21 changes: 21 additions & 0 deletions packages/extensions/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
The MIT License

Copyright (c) 2022 Matt Karl

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
15 changes: 15 additions & 0 deletions packages/extensions/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# @pixi/extensions

## Installation

```bash
npm install @pixi/extensions
```

## Usage

```js
import { extensions } from '@pixi/extensions';

extensions.add(MyCustomExtension);
```
38 changes: 38 additions & 0 deletions packages/extensions/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{
"name": "@pixi/extensions",
"version": "6.5.0",
"main": "dist/cjs/extensions.js",
"module": "dist/esm/extensions.mjs",
"bundle": "dist/browser/extensions.js",
"types": "index.d.ts",
"exports": {
".": {
"import": {
"types": "./index.d.ts",
"default": "./dist/esm/extensions.mjs"
},
"require": {
"types": "./index.d.ts",
"default": "./dist/cjs/extensions.js"
}
}
},
"description": "Installing and uninstalling extensions for PixiJS",
"author": "Matt Karl <matt@mattkarl.com>",
"homepage": "http://pixijs.com/",
"bugs": "https://github.com/pixijs/pixi.js/issues",
"license": "MIT",
"repository": {
"type": "git",
"url": "https://github.com/pixijs/pixi.js.git"
},
"publishConfig": {
"access": "public"
},
"files": [
"lib",
"dist",
"*.d.ts"
]
}

File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { ExtensionMetadata, ExtensionType } from '@pixi/core';
import { extensions } from '@pixi/core';
import type { ExtensionMetadata, ExtensionType } from '@pixi/extensions';
import { extensions } from '@pixi/extensions';

const exampleType = 'test-extension' as ExtensionType;
const exampleType2 = 'test-extension2' as ExtensionType;
Expand Down
1 change: 1 addition & 0 deletions packages/ticker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"*.d.ts"
],
"peerDependencies": {
"@pixi/extensions": "6.5.0",
"@pixi/settings": "6.5.0"
}
}
6 changes: 3 additions & 3 deletions packages/ticker/src/TickerPlugin.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { ExtensionMetadata } from '@pixi/core';
import { ExtensionType } from '@pixi/core';
import type { ExtensionMetadata } from '@pixi/extensions';
import { ExtensionType } from '@pixi/extensions';
import { UPDATE_PRIORITY } from './const';
import { Ticker } from './Ticker';

Expand All @@ -8,7 +8,7 @@ import { Ticker } from './Ticker';
* @example
* import {TickerPlugin} from '@pixi/ticker';
* import {Application} from '@pixi/app';
* import {extensions} from '@pixi/core';
* import {extensions} from '@pixi/extensions';
* extensions.add(TickerPlugin);
* @class
* @memberof PIXI
Expand Down

0 comments on commit 27365ba

Please sign in to comment.